Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show all columns from dataset when transitioning from dashboard to Explore #20701

Closed
wants to merge 1 commit into from

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Jul 13, 2022

SUMMARY

Due to the fact that dashboards use trimmed datasets (they only contain columns used by charts on that dashboard), we can't reuse them in Explore. This PR fixes that behaviour.

This PR is a "subset" of PR #20699 which fixes the same thing, but also introduces a code refactor. CI was failing on that PR, and since it's an urgent bug I decided to open a smaller PR to quickly fix the issue.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #20701 (589d1ef) into master (ec2eb3d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #20701      +/-   ##
==========================================
- Coverage   66.85%   66.84%   -0.02%     
==========================================
  Files        1751     1750       -1     
  Lines       65896    65888       -8     
  Branches     7017     7014       -3     
==========================================
- Hits        44052    44040      -12     
- Misses      20059    20063       +4     
  Partials     1785     1785              
Flag Coverage Δ
javascript 51.94% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/explore/actions/hydrateExplore.ts 57.69% <ø> (-2.31%) ⬇️
...set-frontend/src/explore/actions/exploreActions.ts 50.00% <0.00%> (-8.34%) ⬇️
...rset-frontend/src/hooks/apiResources/dashboards.ts 36.36% <0.00%> (ø)
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <0.00%> (ø)
.../explore/components/ExploreViewContainer/index.jsx 52.19% <0.00%> (ø)
...ters/FiltersConfigModal/FiltersConfigForm/utils.ts 82.35% <0.00%> (ø)
...frontend/src/explore/actions/datasourcesActions.ts
...rset-frontend/src/dashboard/actions/datasources.ts
...rontend/src/explore/reducers/datasourcesReducer.ts
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec2eb3d...589d1ef. Read the comment docs.

@kgabryje kgabryje closed this Jul 14, 2022
@kgabryje
Copy link
Member Author

Closing since the original PR was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants