Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set reference to columns properly for sqllab -> explore #20747

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jul 18, 2022

SUMMARY

Fixing small bug with new query to explore feature, the payload lives in results instead of the upper level component

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@eric-briscoe eric-briscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #20747 (fd5c798) into master (5990ea6) will not change coverage.
The diff coverage is n/a.

❗ Current head fd5c798 differs from pull request most recent head 29d45fa. Consider uploading reports for the commit 29d45fa to get more accurate results

@@           Coverage Diff           @@
##           master   #20747   +/-   ##
=======================================
  Coverage   66.34%   66.34%           
=======================================
  Files        1754     1754           
  Lines       66673    66673           
  Branches     7049     7049           
=======================================
  Hits        44231    44231           
  Misses      20645    20645           
  Partials     1797     1797           
Flag Coverage Δ
javascript 51.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/SqlLab/components/ResultSet/index.tsx 54.07% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5990ea6...29d45fa. Read the comment docs.

@hughhhh hughhhh merged commit 510c1c4 into apache:master Jul 18, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants