Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating thrift #20776

Merged
merged 9 commits into from
Sep 1, 2022
Merged

chore: updating thrift #20776

merged 9 commits into from
Sep 1, 2022

Conversation

nisheldo
Copy link
Contributor

SUMMARY

Updating thrift due to : https://cve.mitre.org/cgi-bin/cvename.cgi?name=2020-13949

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #20776 (d1af9a2) into master (1517956) will decrease coverage by 0.17%.
The diff coverage is n/a.

❗ Current head d1af9a2 differs from pull request most recent head 61c7ae2. Consider uploading reports for the commit 61c7ae2 to get more accurate results

@@            Coverage Diff             @@
##           master   #20776      +/-   ##
==========================================
- Coverage   66.27%   66.10%   -0.18%     
==========================================
  Files        1770     1770              
  Lines       67539    67539              
  Branches     7185     7185              
==========================================
- Hits        44764    44645     -119     
- Misses      20936    21055     +119     
  Partials     1839     1839              
Flag Coverage Δ
hive ?
mysql 80.96% <ø> (ø)
postgres 81.02% <ø> (ø)
presto ?
python 81.13% <ø> (-0.37%) ⬇️
sqlite 79.62% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 71.04% <0.00%> (-15.84%) ⬇️
superset/db_engine_specs/presto.py 81.36% <0.00%> (-6.62%) ⬇️
superset/models/sql_lab.py 75.00% <0.00%> (-2.02%) ⬇️
superset/initialization/__init__.py 89.96% <0.00%> (-1.74%) ⬇️
superset/connectors/sqla/models.py 89.62% <0.00%> (-0.71%) ⬇️
superset/db_engine_specs/base.py 88.11% <0.00%> (-0.33%) ⬇️
superset/models/core.py 88.51% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 90.12% <0.00%> (-0.12%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing this!

@villebro villebro merged commit 6d65f80 into apache:master Sep 1, 2022
@nisheldo nisheldo deleted the update-thrift branch September 1, 2022 18:44
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants