feat: Add Türkiye Map to Country Map #20801
Conversation
rizacavus
changed the title
Codecov Report
@@ Coverage Diff @@
## master #20801 +/- ##
==========================================
- Coverage 66.80% 66.78% -0.02%
==========================================
Files 1754 1753 -1
Lines 65572 66023 +451
Branches 6933 7059 +126
==========================================
+ Hits 43804 44094 +290
- Misses 20014 20131 +117
- Partials 1754 1798 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
| @@ -154,6 +156,9 @@ export const countryOptions = Object.keys(countries).map(x => { | |||
| if (x === 'italy_regions') { | |||
| return [x, 'Italy (regions)']; | |||
| } | |||
| if (x === 'turkey') { | |||
There was a problem hiding this comment.
Thanks a lot for the contribution. might we keep the country name as English(Because many users cannot input non-ascii characters)?
There was a problem hiding this comment.
It was actually like that, but asked to changed to Türkiye on #20698 and waits for review for 5 days :/
There was a problem hiding this comment.
Sorry for the waiting long time. I have approved. just waiting for the CI.
There was a problem hiding this comment.
@srinify could we keep the country name in English?
There was a problem hiding this comment.
I have changed it to Turkey
Turkey map already added with "feat: Add Türkiye Map to Country Map apache#20801"
mistercrunch
added
🏷️ bot
SUMMARY
Add Türkiye Map to Country Map
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Clone the repo and go to its root directory. Run the following shell commands:
cd superset-frontend && npm install
npm run plugins:storybook
ADDITIONAL INFORMATION