Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create property for schema_perm for Query #20871

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jul 26, 2022

SUMMARY

To allow users to query data from adhoc queries, we need add the property schema_perm to validate if the current user has access to run this query based upon the database and schema.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #20871 (0adb501) into master (a69f016) will decrease coverage by 11.49%.
The diff coverage is 50.00%.

❗ Current head 0adb501 differs from pull request most recent head 34560e3. Consider uploading reports for the commit 34560e3 to get more accurate results

@@             Coverage Diff             @@
##           master   #20871       +/-   ##
===========================================
- Coverage   66.27%   54.78%   -11.50%     
===========================================
  Files        1757     1757               
  Lines       66962    66958        -4     
  Branches     7109     7109               
===========================================
- Hits        44380    36683     -7697     
- Misses      20767    28460     +7693     
  Partials     1815     1815               
Flag Coverage Δ
hive 53.25% <75.00%> (-0.01%) ⬇️
mysql ?
postgres ?
presto 53.11% <75.00%> (-0.01%) ⬇️
python 57.82% <75.00%> (-23.77%) ⬇️
sqlite ?
unit 50.27% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ols/DndColumnSelectControl/ColumnSelectPopover.tsx 3.75% <0.00%> (ø)
...ColumnSelectControl/ColumnSelectPopoverTrigger.tsx 65.51% <66.66%> (ø)
superset/models/sql_lab.py 72.32% <66.66%> (-5.06%) ⬇️
...ols/MetricControl/AdhocMetricEditPopover/index.jsx 78.02% <100.00%> (ø)
...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx 83.78% <100.00%> (ø)
superset/security/manager.py 64.35% <100.00%> (-31.21%) ⬇️
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-88.89%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-80.77%) ⬇️
... and 288 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@hughhhh hughhhh merged commit 35184b2 into apache:master Jul 27, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants