Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Drill modal apply all of the filters #20912

Closed
wants to merge 10 commits into from

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Jul 29, 2022

SUMMARY

This PR follow-up PR from Cody, the new commit has only one purpose, to apply all the column filters(time filter/adhoc filter/native filter/....) to the drill detail query but remove all having filter.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

drill.to.detail.with.filters.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina
Copy link
Member

Thank you for the PR @zhaoyongjie!

I noticed that when passing a different drillFilters param to DrillDetailPane, the query isn't updating.

@zhaoyongjie
Copy link
Member Author

zhaoyongjie commented Jul 29, 2022

I noticed that when passing a different drillFilters param to DrillDetailPane, the query isn't updating.

Thanks @michael-s-molina I will update these on the cody's PR.

@zhaoyongjie
Copy link
Member Author

zhaoyongjie commented Jul 29, 2022

The commit has cherry-pick to cody's PR, so I close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants