Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): Time controls not showing for Queries #20923

Conversation

eric-briscoe
Copy link
Contributor

SUMMARY

Time column went missing after creating charts from query

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before with bug:
Clipboard 2022-22-07 at 4 58 49 PM

With Fix:
Screen Shot 2022-07-29 at 1 44 14 PM

TESTING INSTRUCTIONS

  1. Verify the Explore Time panel shows the correct time components - Time Column & Time Grain
  2. Enable the "Create Chart" button in SQL Lab to open explore
  3. Create and run a query
  4. Click the "Create Chart" button
  5. Verify the time controls show correctly (same as they do for dataset)
    Expected Controls when in Explore when datasource type is table or query:

Screen Shot 2022-07-29 at 1 44 14 PM

Time Column & Time Grain ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [X] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com//issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API

@hughhhh hughhhh self-requested a review July 29, 2022 21:44
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #20923 (a354269) into master (06d0539) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #20923   +/-   ##
=======================================
  Coverage   66.31%   66.31%           
=======================================
  Files        1758     1758           
  Lines       67039    67040    +1     
  Branches     7116     7116           
=======================================
+ Hits        44457    44458    +1     
  Misses      20752    20752           
  Partials     1830     1830           
Flag Coverage Δ
javascript 52.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/explore/controlUtils/getSectionsToRender.ts 80.95% <100.00%> (+0.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@hughhhh hughhhh merged commit 1a8c28d into apache:master Jul 29, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants