chore(db): ensure query_context is MediumText before viz migration #20936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktmud
force-pushed
the
ensure-query-context-medium-text
branch
from
64c0ea7
to
7ffd95a
Compare
john-bodley
reviewed
Aug 2, 2022
| # which may significantly increase the size of these fields. | ||
| if isinstance(op.get_bind().dialect, MySQLDialect): | ||
| # If the columns are already MEDIUMTEXT, this is a no-op | ||
| op.execute("ALTER TABLE slices MODIFY params MEDIUMTEXT") |
There was a problem hiding this comment.
@ktmud why raw SQL here and not the Alembic alter_column method?
There was a problem hiding this comment.
Because this is only for one dialect and raw SQL is easier to read. People can also copy the statement directly if they ever want to test it manually.
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Since #20779 will just be an no-op if the columns are already MediumText, let's just do it again before the viz migration. This way, administrators don't have to remember to manually migrate the columns before running
superset db migration.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
CI and tested locally via
superset db upgrade.ADDITIONAL INFORMATION