Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): Fix scroll behaviour in DashboardBuilderSidepane #20969

Merged
merged 2 commits into from
Aug 16, 2022
Merged

fix(dashboard): Fix scroll behaviour in DashboardBuilderSidepane #20969

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df9b318
fix(dashboard): Fix scroll behaviour in DashboardBuilderSidepane
EugeneTorap Aug 4, 2022
a913b18
Merge branch 'master' into fix/scroll-in-dash-sidepane
EugeneTorap Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 2 additions & 13 deletions superset-frontend/src/dashboard/components/BuilderComponentPane/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ export interface BCPProps {

const SUPERSET_HEADER_HEIGHT = 59;
const SIDEPANE_ADJUST_OFFSET = 4;
const SIDEPANE_HEADER_HEIGHT = 64; // including margins
const SIDEPANE_FILTERBAR_HEIGHT = 56;
const TOP_PANEL_OFFSET = 210;

const BuilderComponentPaneTabs = styled(Tabs)`
line-height: inherit;
Expand All @@ -52,20 +51,10 @@ const BuilderComponentPaneTabs = styled(Tabs)`
const DashboardBuilderSidepane = styled.div<{
topOffset: number;
}>`
height: 100%;
height: calc(100% - ${TOP_PANEL_OFFSET}px);
position: fixed;
right: 0;
top: 0;

.ReactVirtualized__List {
padding-bottom: ${({ topOffset }) =>
`${
SIDEPANE_HEADER_HEIGHT +
SIDEPANE_FILTERBAR_HEIGHT +
SIDEPANE_ADJUST_OFFSET +
topOffset
}px`};
}
`;

const BuilderComponentPane: React.FC<BCPProps> = ({
Expand Down