-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Memoize the common_bootstrap_payload #21018
perf: Memoize the common_bootstrap_payload #21018
Conversation
a9b2596
to
6a426cd
Compare
3db56e6
to
1e31838
Compare
Codecov Report
@@ Coverage Diff @@
## master #21018 +/- ##
==========================================
- Coverage 66.38% 66.18% -0.21%
==========================================
Files 1767 1767
Lines 67232 67350 +118
Branches 7138 7144 +6
==========================================
- Hits 44633 44574 -59
- Misses 20773 20948 +175
- Partials 1826 1828 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
1e31838
to
d14ad97
Compare
Try patch
d14ad97
to
d62edd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Try patch Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com> (cherry picked from commit 495a205)
…ache#21018) (apache#21439) Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>
Try patch Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com> (cherry picked from commit 495a205)
(cherry picked from commit 094400c)
(cherry picked from commit 094400c)
SUMMARY
Memoize the common_bootstrap_payload. The function includes the config settings and the feature flags, those tend to be changed in frequently, this PR adds caching layer with 1 minute TTL. In our staging deployment it yields 10x speedup e.g. 22 ms down from ~250 ms
BEFORE
AFTER
TESTING INSTRUCTIONS
[x] Dropbox staging