Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert-modal): Radio button is not vertically-aligned #21140

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

paulo-eduardo
Copy link
Contributor

SUMMARY

Removing bottom margin to align checkbox with the inputs on his side.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

Screen.Recording.2022-08-19.at.15.36.49.mov

AFTER

Screen.Recording.2022-08-19.at.15.37.43.mov

TESTING INSTRUCTIONS

  • Click Settings in the top right corner
  • Select Alerts & Reports
  • Click + Alert OR switch to the Reports tab (using the tab switcher in the top left) and click + Report

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #21140 (8369131) into master (642a0d7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21140   +/-   ##
=======================================
  Coverage   66.26%   66.26%           
=======================================
  Files        1772     1772           
  Lines       67649    67649           
  Branches     7205     7205           
=======================================
  Hits        44825    44825           
  Misses      20981    20981           
  Partials     1843     1843           
Flag Coverage Δ
javascript 52.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/components/CronPicker/CronPicker.tsx 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improvement!

@stephenLYZ stephenLYZ merged commit 74e40c2 into apache:master Aug 25, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants