Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds drill to detail context menu to World Map #21150

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Adds drill-to-detail context menu to World Map chart.

World Map is a legacy plugin with some limitations like re-rendering the whole map from scratch for every property change. That's why you will notice a blinking effect when right-clicking a country or changing the color of the bubbles. Is not the objective of this PR to change this behavior. Another limitation is the possibility of keeping a country in a hovered state when interacting with the context menu. Many of these limitations can be resolved by migrating the World Map to ECharts.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-08-22.at.10.23.34.AM.mov

TESTING INSTRUCTIONS

1 - You should be able to right-click both the country and the bubbles
2 - Check the value and formatted value when right-clicking
3 - When the context menu is active, both labels and hovered effects are disabled for other countries

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #21150 (a12260f) into master (94e8fd3) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #21150      +/-   ##
==========================================
+ Coverage   66.27%   66.29%   +0.02%     
==========================================
  Files        1770     1773       +3     
  Lines       67543    67655     +112     
  Branches     7185     7214      +29     
==========================================
+ Hits        44764    44855      +91     
- Misses      20940    20957      +17     
- Partials     1839     1843       +4     
Flag Coverage Δ
javascript 52.09% <0.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gins/legacy-plugin-chart-world-map/src/WorldMap.js 0.00% <0.00%> (ø)
...egacy-plugin-chart-world-map/src/transformProps.js 0.00% <0.00%> (ø)
...n-chart-handlebars/src/plugin/controls/orderBy.tsx 28.57% <0.00%> (-11.43%) ⬇️
superset-frontend/src/views/components/Menu.tsx 49.23% <0.00%> (-0.77%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 59.83% <0.00%> (-0.28%) ⬇️
...et-frontend/src/components/TableSelector/index.tsx 76.08% <0.00%> (ø)
...ackages/superset-ui-core/src/query/types/Filter.ts 100.00% <0.00%> (ø)
...lugin-chart-handlebars/src/plugin/controlPanel.tsx 50.00% <0.00%> (ø)
...rset-frontend/src/components/MetadataBar/index.tsx 96.00% <0.00%> (ø)
...s/controls/ColorSchemeControl/ColorSchemeLabel.tsx 63.63% <0.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@geido
Copy link
Member

geido commented Aug 23, 2022

/testenv up FEATURE_DRILL_TO_DETAIL=true

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://35.92.119.140:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit 4ca4a5c into apache:master Aug 23, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants