fix: Drill to detail on values with comma #21151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
approved these changes
Aug 22, 2022
zhaoyongjie
reviewed
Aug 22, 2022
| @@ -39,12 +39,12 @@ export type QueryObjectFilterClause = { | |||
| } & ( | |||
| | { | |||
| op: BinaryOperator; | |||
| val: string | number | boolean; | |||
| val: string | number | boolean | null | Date; | |||
There was a problem hiding this comment.
Why use Date and null object on the filter?
There was a problem hiding this comment.
Because the values come from the labelMap:
interface EChartTransformedProps<F> {
labelMap: Record<string, DataRecordValue[]>;
...
}
type DataRecordValue = number | string | boolean | Date | null;
zhaoyongjie
reviewed
Aug 22, 2022
| @@ -83,6 +83,7 @@ export interface ChartDataResponseResult { | |||
| export interface TimeseriesChartDataResponseResult | |||
| extends ChartDataResponseResult { | |||
| data: TimeseriesDataRecord[]; | |||
| label_map: Record<string, DataRecordValue[]>; | |||
There was a problem hiding this comment.
nits:
Suggested change
| label_map: Record<string, DataRecordValue[]>; | |
| label_map: Record<string, string[]>; |
There was a problem hiding this comment.
I'm using DataRecordValue to keep compatibility with labelMap defined in EChartTransformedProps.
There was a problem hiding this comment.
the value of label_map represents parts of columns, it will not be null or Date.
There was a problem hiding this comment.
Got it. I'll open a follow-up to fix all labelMap references then.
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes a bug that was causing incorrect values when right-clicking on charts that contain values with commas.
Original issue: #20728 (comment)
@codyml
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-08-22.at.11.39.09.AM.mov
TESTING INSTRUCTIONS
Check that the correct values are displayed when interacting with charts that contain values with commas.
ADDITIONAL INFORMATION