-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Reimplement permissions fetching to do it in a single transaction #21156
perf: Reimplement permissions fetching to do it in a single transaction #21156
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21156 +/- ##
===========================================
- Coverage 66.27% 54.89% -11.38%
===========================================
Files 1770 1779 +9
Lines 67543 67838 +295
Branches 7185 7237 +52
===========================================
- Hits 44764 37242 -7522
- Misses 20940 28744 +7804
- Partials 1839 1852 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1803d96
to
c38925c
Compare
c38925c
to
84e0546
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…tion (apache#21156)" This reverts commit ed6212a.
…tion (apache#21156)" This reverts commit ed6212a
…tion (apache#21156)" This reverts commit ed6212a
SUMMARY
Reimplement permissions fetching to do it in a single transaction.
It reduces latency from ~1 second to ~120 ms on our deployment
BEFORE
AFTER
TESTING INSTRUCTIONS
[x] CI
[x] Dropbox Staging