Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add new e2e tests for Explore #21184

Merged
merged 5 commits into from
Aug 25, 2022

Conversation

kgabryje
Copy link
Member

SUMMARY

  1. Creating a chart from dataset list:
  • Open dataset list
  • Click on dataset name
  • Explore should open with the clicked dataset selected and table chart set by default
  1. Creating a chart from SqlLab
  • Open SqlLab run type a query
  • Click Create Chart
  • Explore should open with the query from SqlLab as source, table chart set by default and columns selected in the query set as columns in table chart
  1. Editing dataset from Explore (re-enable and fix skipped test):
  • Click Edit dataset
  • Add new metric
  • Add the new metric to metrics control
  • Click Edit dataset
  • Delete the newly added metric
  • Verify that it was removed from metrics control

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje
Copy link
Member Author

@adam-stasiak Can you take a look? 🙏

Copy link
Contributor

@adam-stasiak adam-stasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #21184 (9e3746c) into master (756ed0e) will increase coverage by 0.10%.
The diff coverage is 52.45%.

❗ Current head 9e3746c differs from pull request most recent head ca114ee. Consider uploading reports for the commit ca114ee to get more accurate results

@@            Coverage Diff             @@
##           master   #21184      +/-   ##
==========================================
+ Coverage   66.29%   66.39%   +0.10%     
==========================================
  Files        1773     1781       +8     
  Lines       67680    67893     +213     
  Branches     7214     7248      +34     
==========================================
+ Hits        44866    45077     +211     
+ Misses      20971    20954      -17     
- Partials     1843     1862      +19     
Flag Coverage Δ
javascript 52.30% <48.53%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...packages/superset-ui-core/src/query/types/Query.ts 100.00% <ø> (ø)
...gins/legacy-plugin-chart-world-map/src/WorldMap.js 0.00% <0.00%> (ø)
...egacy-plugin-chart-world-map/src/transformProps.js 0.00% <0.00%> (ø)
...ns/plugin-chart-echarts/src/Gauge/EchartsGauge.tsx 0.00% <0.00%> (ø)
...rts/src/MixedTimeseries/EchartsMixedTimeseries.tsx 0.00% <0.00%> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
...chart-echarts/src/Timeseries/EchartsTimeseries.tsx 0.00% <0.00%> (ø)
...ns/plugin-chart-echarts/src/utils/eventHandlers.ts 0.00% <0.00%> (ø)
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (ø)
superset-frontend/src/SqlLab/types.ts 57.14% <ø> (ø)
... and 81 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more


cy.get(
'.SouthPane .ant-tabs-content > .ant-tabs-tabpane-active > div button:first',
{ timeout: 10000 },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, what's the reason of this high timeout?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes there was a small delay in rendering the component with buttons. Even though we wait for the query to finish, the test was flaky because cypress couldn't find the button because of that delay. A smaller timeout would probably work just as well though

@kgabryje kgabryje merged commit 17ad0d8 into apache:master Aug 25, 2022
@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants