Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter with created_by for charts and dashboards #21199

Merged

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented Aug 25, 2022

SUMMARY

  • add filters to Charts and Dashboards to filter out created_by is None

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lilykuang lilykuang marked this pull request as ready for review August 25, 2022 18:13
@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 25, 2022
@lilykuang lilykuang requested review from geido and riahk August 25, 2022 20:31
@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #21199 (1dfedbe) into master (1aa1864) will decrease coverage by 0.18%.
The diff coverage is 44.44%.

❗ Current head 1dfedbe differs from pull request most recent head 88dbc22. Consider uploading reports for the commit 88dbc22 to get more accurate results

@@            Coverage Diff             @@
##           master   #21199      +/-   ##
==========================================
- Coverage   66.43%   66.25%   -0.19%     
==========================================
  Files        1784     1784              
  Lines       68167    68185      +18     
  Branches     7265     7265              
==========================================
- Hits        45290    45179     -111     
- Misses      21008    21137     +129     
  Partials     1869     1869              
Flag Coverage Δ
hive ?
mysql 80.81% <44.44%> (-0.02%) ⬇️
postgres 80.86% <44.44%> (-0.02%) ⬇️
presto ?
python 80.97% <44.44%> (-0.39%) ⬇️
sqlite 79.38% <44.44%> (-0.02%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/api.py 85.98% <ø> (ø)
superset/dashboards/api.py 92.50% <ø> (ø)
superset/charts/filters.py 85.41% <44.44%> (-9.46%) ⬇️
superset/dashboards/filters.py 88.76% <44.44%> (-4.99%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 71.09% <0.00%> (-16.02%) ⬇️
superset/db_engine_specs/presto.py 81.32% <0.00%> (-6.63%) ⬇️
superset/models/sql_lab.py 74.90% <0.00%> (-2.00%) ⬇️
superset/initialization/__init__.py 89.96% <0.00%> (-1.74%) ⬇️
superset/connectors/sqla/models.py 89.79% <0.00%> (-0.71%) ⬇️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a failing test that needs fixing. Code LGTM!

@lilykuang lilykuang merged commit 05354a9 into apache:master Aug 30, 2022
@lilykuang lilykuang deleted the lilykuang/chart-dashboard-created-by-filter branch August 30, 2022 19:27
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Aug 30, 2022
* feat: filter with created_by for charts and dashboards

* add tests

* update tests

* update tests

(cherry picked from commit 05354a9)
@sadpandajoe
Copy link
Contributor

🏷️ preset:2022.35

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.35 size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants