Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): import-directory is missing the application context #21255

Merged
merged 1 commit into from
Aug 23, 2023
Merged

fix(cli): import-directory is missing the application context #21255

merged 1 commit into from
Aug 23, 2023

Conversation

rdubois
Copy link
Contributor

@rdubois rdubois commented Aug 30, 2022 •
edited
Loading

See the #21254 for description and details

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Missing application context in the import_directory CLI function #21254
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rdubois rdubois mentioned this pull request Sep 1, 2022
Closed
3 tasks
@rusackas
Copy link
Member

Closing and re-opening to reboot CI. Also pinging @betodealmeida as the original author of the split for a second pair of eyes.

@rusackas rusackas closed this Aug 23, 2023
@rusackas rusackas reopened this Aug 23, 2023
@rusackas rusackas merged commit 80fcbfa into apache:master Aug 23, 2023
31 checks passed
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 24, 2023
michael-s-molina pushed a commit that referenced this pull request Aug 24, 2023
@rdubois @michael-s-molina
fix(cli): import-directory is missing the application context (#21255)
2554a89 
(cherry picked from commit 80fcbfa)
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@alexandercarruthers alexandercarruthers alexandercarruthers approved these changes

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

Assignees

@rusackas rusackas

Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing application context in the import_directory CLI function
5 participants
@rdubois @rusackas @alexandercarruthers @mistercrunch @michael-s-molina