Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds a helper text option to the Select component #21269

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Adds a helper text option to the Select component to aid users when dealing with more complex flows.

@kasiazjc @codyml @cccs-RyanK

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-08-31.at.10.53.55.AM.mov

TESTING INSTRUCTIONS

Check the video for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #21269 (3881e58) into master (6223042) will increase coverage by 0.01%.
The diff coverage is 87.27%.

❗ Current head 3881e58 differs from pull request most recent head 69edd74. Consider uploading reports for the commit 69edd74 to get more accurate results

@@            Coverage Diff             @@
##           master   #21269      +/-   ##
==========================================
+ Coverage   66.43%   66.45%   +0.01%     
==========================================
  Files        1784     1784              
  Lines       68185    68243      +58     
  Branches     7265     7265              
==========================================
+ Hits        45298    45348      +50     
- Misses      21018    21026       +8     
  Partials     1869     1869              
Flag Coverage Δ
javascript 52.49% <52.38%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...chart-echarts/src/Timeseries/Regular/Line/index.ts 33.33% <ø> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 61.05% <0.00%> (-0.33%) ⬇️
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 52.87% <0.00%> (ø)
...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx 60.00% <ø> (ø)
...c/views/CRUD/data/database/DatabaseModal/index.tsx 32.03% <0.00%> (-0.17%) ⬇️
superset/datasets/commands/delete.py 97.14% <ø> (+3.96%) ⬆️
superset/databases/commands/update.py 79.71% <25.00%> (-11.52%) ⬇️
superset/security/manager.py 95.41% <98.21%> (+0.33%) ⬆️
...rontend/src/components/ErrorMessage/ErrorAlert.tsx 89.47% <100.00%> (-0.78%) ⬇️
...-frontend/src/components/FilterableTable/index.tsx 72.63% <100.00%> (+0.29%) ⬆️
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

superset-frontend/src/components/Select/Select.test.tsx Outdated Show resolved Hide resolved
@@ -162,6 +170,16 @@ const StyledLoadingText = styled.div`
`}
`;

const StyledHelperText = styled.div`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks identical to the AsyncSelect one. Should we put in a common file and import it from there?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I left it duplicated on purpose in this PR because @cccs-RyanK is already working on the common file in #21094

michael-s-molina and others added 2 commits September 1, 2022 08:46
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit fbe9807 into apache:master Sep 2, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants