Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump min version of elastic search #21274

Merged
merged 3 commits into from
Aug 31, 2022
Merged

fix: bump min version of elastic search #21274

merged 3 commits into from
Aug 31, 2022

Conversation

AAfghahi
Copy link
Member

SUMMARY

with our change to sql alchemy 1.4 we need to change the minimum version of elastic search because older versions don't work with 1.4.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #21274 (6442fd2) into master (0c87ff7) will decrease coverage by 11.38%.
The diff coverage is 82.30%.

❗ Current head 6442fd2 differs from pull request most recent head 3d21cb0. Consider uploading reports for the commit 3d21cb0 to get more accurate results

@@             Coverage Diff             @@
##           master   #21274       +/-   ##
===========================================
- Coverage   66.41%   55.03%   -11.39%     
===========================================
  Files        1784     1784               
  Lines       68185    68232       +47     
  Branches     7265     7265               
===========================================
- Hits        45284    37550     -7734     
- Misses      21032    28813     +7781     
  Partials     1869     1869               
Flag Coverage Δ
hive 52.99% <60.00%> (-0.03%) ⬇️
postgres ?
presto 52.89% <60.00%> (-0.03%) ⬇️
python 57.74% <82.30%> (-23.56%) ⬇️
sqlite ?
unit 50.75% <81.53%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/datasets/commands/delete.py 48.57% <ø> (-44.62%) ⬇️
superset/databases/commands/update.py 26.08% <25.00%> (-65.15%) ⬇️
superset/security/manager.py 61.39% <87.50%> (-33.69%) ⬇️
superset/connectors/sqla/models.py 77.76% <100.00%> (-12.74%) ⬇️
superset/datasets/commands/create.py 31.25% <100.00%> (-66.79%) ⬇️
superset/models/core.py 78.48% <100.00%> (-9.70%) ⬇️
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-88.89%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-80.77%) ⬇️
... and 286 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AAfghahi AAfghahi requested a review from hughhhh August 31, 2022 18:14
@hughhhh hughhhh merged commit 9c4ae2a into master Aug 31, 2022
@AAfghahi AAfghahi deleted the arash/bump_elastic branch August 31, 2022 20:07
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants