fix: flaky test when sync metadata #21306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21306 +/- ##
==========================================
- Coverage 66.39% 66.27% -0.12%
==========================================
Files 1784 1789 +5
Lines 68232 68291 +59
Branches 7263 7273 +10
==========================================
- Hits 45305 45263 -42
- Misses 21058 21153 +95
- Partials 1869 1875 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zhaoyongjie
force-pushed
the
fix/flasky_test
branch
from
20661a5
to
72d2963
Compare
zhaoyongjie
commented
Sep 2, 2022
Comment on lines
-475
to
-476
| db.session.delete(table) | ||
|
|
There was a problem hiding this comment.
table isn't persisted.
| @@ -453,7 +453,8 @@ def test_fetch_metadata_for_updated_virtual_table(self): | |||
|
|
|||
| # make sure the columns have been mapped properly | |||
| assert len(table.columns) == 4 | |||
| table.fetch_metadata(commit=False) | |||
| with db.session.no_autoflush: | |||
There was a problem hiding this comment.
keep the table in client memory other than writing to DB
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
trying to fix a flaky test on the master
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION