Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade yeoman-generator to fix security warnings #21324

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 4, 2022

Codecov Report

Merging #21324 (7d08143) into master (1cc2148) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21324      +/-   ##
==========================================
+ Coverage   66.47%   66.56%   +0.08%     
==========================================
  Files        1789     1790       +1     
  Lines       68381    68391      +10     
  Branches     7276     7279       +3     
==========================================
+ Hits        45455    45523      +68     
+ Misses      21051    20991      -60     
- Partials     1875     1877       +2     
Flag Coverage Δ
javascript 52.68% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cy-preset-chart-nvd3/src/TimePivot/controlPanel.ts 33.33% <0.00%> (-16.67%) ⬇️
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 56.60% <0.00%> (-0.54%) ⬇️
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 58.97% <0.00%> (-0.16%) ⬇️
...end/src/dashboard/components/dnd/DragDroppable.jsx 76.92% <0.00%> (ø)
...ashboard/components/gridComponents/ChartHolder.jsx
...ashboard/components/gridComponents/ChartHolder.tsx 88.88% <0.00%> (ø)
...rc/dashboard/util/useFilterFocusHighlightStyles.ts 100.00% <0.00%> (ø)
...-frontend/src/dashboard/reducers/dashboardState.js 76.59% <0.00%> (+2.12%) ⬆️
...hboard/components/resizable/ResizableContainer.jsx 61.70% <0.00%> (+4.25%) ⬆️
...e/components/controls/ColorSchemeControl/index.jsx 78.57% <0.00%> (+11.90%) ⬆️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a bycatch comment

"superset",
"yeoman-generator"
],
"homepage": "https://github.com/apache-superset/superset-ui#readme",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here, maybe we want to move this to reference the apache/superset repo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! Good Catch!

@stephenLYZ stephenLYZ merged commit a27c7ae into apache:master Sep 6, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants