Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds MetadataBar to Drill to Detail modal #21343

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Adds MetadataBar to Drill to Detail modal:

  • Changes the dataset API to include additional fields
  • Moves the MetadataBar code outside of index.tsx
  • Adds tests

PS: Row count is outside the scope of this PR because it needs bigger changes to the API and it will be handled in its own PR.

@kasiazjc @codyml

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-09-06.at.8.56.29.AM.mov

TESTING INSTRUCTIONS

Check the video for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

* To extend the list of content types, a developer needs to request the inclusion of the new type in the design system.
* This process is important to make sure the new type is reviewed by the design team, improving Superset consistency.
*/
const MetadataBar = ({ items }: MetadataBarProps) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just moved the component. No code changes.

@kasiazjc
Copy link
Contributor

kasiazjc commented Sep 6, 2022

looks good, thank you @michael-s-molina! 🙏

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #21343 (e34ee80) into master (c3a00d4) will increase coverage by 0.10%.
The diff coverage is 74.25%.

❗ Current head e34ee80 differs from pull request most recent head f4dd980. Consider uploading reports for the commit f4dd980 to get more accurate results

@@            Coverage Diff             @@
##           master   #21343      +/-   ##
==========================================
+ Coverage   66.44%   66.54%   +0.10%     
==========================================
  Files        1786     1791       +5     
  Lines       68267    68502     +235     
  Branches     7263     7308      +45     
==========================================
+ Hits        45357    45587     +230     
+ Misses      21041    21030      -11     
- Partials     1869     1885      +16     
Flag Coverage Δ
hive 52.97% <40.32%> (-0.06%) ⬇️
javascript 52.74% <73.39%> (+0.25%) ⬆️
postgres 80.88% <76.34%> (-0.01%) ⬇️
presto 52.87% <40.32%> (-0.05%) ⬇️
python 81.26% <76.34%> (-0.06%) ⬇️
sqlite ?
unit 50.83% <43.54%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-controls/src/sections/echartsTimeSeriesQuery.tsx 33.33% <0.00%> (-16.67%) ⬇️
...ackages/superset-ui-core/src/query/types/Column.ts 100.00% <ø> (ø)
...cy-preset-chart-nvd3/src/TimePivot/controlPanel.ts 33.33% <0.00%> (-16.67%) ⬇️
...chart-echarts/src/MixedTimeseries/controlPanel.tsx 54.16% <ø> (ø)
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 40.00% <ø> (ø)
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 31.25% <ø> (ø)
...harts/src/Timeseries/Regular/Line/controlPanel.tsx 33.33% <ø> (ø)
...ts/src/Timeseries/Regular/Scatter/controlPanel.tsx 40.00% <ø> (ø)
...src/Timeseries/Regular/SmoothLine/controlPanel.tsx 40.00% <ø> (ø)
...chart-echarts/src/Timeseries/Step/controlPanel.tsx 33.33% <ø> (ø)
... and 99 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick first pass. Thanks for the new feature.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit 8ebf4ed into apache:master Sep 8, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants