Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove blank space from users filters #21346

Merged

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented Sep 6, 2022

SUMMARY

  • only show users filters with users that have first name or last name

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #21346 (fec6b55) into master (ce3d38d) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #21346      +/-   ##
==========================================
- Coverage   66.61%   66.57%   -0.04%     
==========================================
  Files        1791     1791              
  Lines       68481    68446      -35     
  Branches     7299     7299              
==========================================
- Hits        45617    45570      -47     
- Misses      20978    20996      +18     
+ Partials     1886     1880       -6     
Flag Coverage Δ
javascript 52.73% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/CRUD/utils.tsx 64.28% <0.00%> (-0.52%) ⬇️
...rd/components/nativeFilters/FilterBar/keyValue.tsx 18.51% <0.00%> (-22.23%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 60.14% <0.00%> (-5.80%) ⬇️
superset/views/utils.py 80.00% <0.00%> (-0.85%) ⬇️
superset/connectors/sqla/utils.py 88.63% <0.00%> (-0.58%) ⬇️
superset/security/manager.py 95.41% <0.00%> (-0.31%) ⬇️
superset/connectors/sqla/models.py 90.50% <0.00%> (-0.10%) ⬇️
superset/superset_typing.py 98.11% <0.00%> (-0.07%) ⬇️
superset/views/base_api.py 98.38% <0.00%> (-0.07%) ⬇️
superset/utils/core.py 90.39% <0.00%> (+0.39%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lilykuang lilykuang changed the title chore: only show users filters that have first name and last name chore: only show users filters for user with first name or last name Sep 7, 2022
@lilykuang lilykuang changed the title chore: only show users filters for user with first name or last name chore: remove blank space from users filters Sep 7, 2022
@rusackas
Copy link
Member

rusackas commented Sep 9, 2022

Tests would be a nice addition if possible, but the logic here is pretty straightforward, it seems.

@lilykuang lilykuang merged commit 973d870 into apache:master Sep 13, 2022
@lilykuang lilykuang deleted the lilykuang/user-without-firstname-lastname branch September 13, 2022 21:10
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants