test: Fix act errors in FaveStar test #21360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21360 +/- ##
==========================================
- Coverage 66.61% 66.59% -0.03%
==========================================
Files 1791 1791
Lines 68481 68481
Branches 7299 7299
==========================================
- Hits 45617 45603 -14
- Misses 20978 20998 +20
+ Partials 1886 1880 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -26,13 +26,13 @@ jest.mock('src/components/Tooltip', () => ({ | |||
| Tooltip: (props: any) => <div data-test="tooltip" {...props} />, | |||
| })); | |||
|
|
|||
| test('render right content', () => { | |||
| it('render right content', async () => { | |||
There was a problem hiding this comment.
Suggested change
| it('render right content', async () => { | |
| test('render right content', async () => { |
| @@ -54,7 +54,7 @@ test('render right content', () => { | |||
| expect(props.saveFaveStar).toBeCalledWith(props.itemId, false); | |||
| }); | |||
|
|
|||
| test('render content on tooltip', () => { | |||
| it('render content on tooltip', async () => { | |||
There was a problem hiding this comment.
Suggested change
| it('render content on tooltip', async () => { | |
| test('render content on tooltip', async () => { |
| @@ -75,7 +75,7 @@ test('render content on tooltip', () => { | |||
| expect(screen.getByRole('button')).toBeInTheDocument(); | |||
| }); | |||
|
|
|||
| test('Call fetchFaveStar only on the first render', () => { | |||
| it('Call fetchFaveStar only on the first render', async () => { | |||
There was a problem hiding this comment.
Suggested change
| it('Call fetchFaveStar only on the first render', async () => { | |
| test('Call fetchFaveStar only on the first render', async () => { |
michael-s-molina
approved these changes
Sep 8, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes 3 act errors in
superset-frontend/src/components/FaveStar/FaveStar.test.tsxTESTING INSTRUCTIONS
superset-frontend/src/components/FaveStarnpm run test superset-frontend/src/components/FaveStar/FaveStar.test.tsxADDITIONAL INFORMATION