fix(sqllab): Fix cursor alignment in SQL lab editor by avoiding Lucida Console font on Windows

[MichaelHintz]

SUMMARY

Windows does not have a bold version of Lucida Console installed by default. [1] [2]
Instead, Windows creates a fake bold version of the font, which is slightly wider. [3]

In the SQL lab editor this leads to the cursor alignment issues linked below.

Consolas and Courier New both come with bold monospaced version pre-installed on Windows [2] and cause no issues with cursor alignment. That is why I am proposing to change the order of the fonts.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Available in any of the linked issues

TESTING INSTRUCTIONS

Requirement: Windows machine with standard fonts, meaning Menlo is not installed, Lucida Console is installed, but missing the bold version.

Then just type any SQL keyword the SQL lab editor, such as SELECT * FROM table_name.
The cursor is no longer aligned over the word table_name.
This is fixed when the font order is changed via the browser's development tools

ADDITIONAL INFORMATION

• Has associated issue:
  Fixes Cursor falls behind in SQL Lab #9253
  Fixes Cursor falling behind in SQL Lab #15749
  Fixes sqllab cursor misplaced #19094
  Fixes text cursor algin did not fix the text in sqlLab. #19580
  Fixes Cursor falls behind in SQL Lab #20436
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

[codecov]

Codecov Report

Merging #21380 (6f32d31) into master (b80f659) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21380   +/-   ##
=======================================
  Coverage   66.60%   66.60%           
=======================================
  Files        1791     1791           
  Lines       68559    68559           
  Branches     7319     7319           
=======================================
  Hits        45666    45666           
  Misses      21007    21007           
  Partials     1886     1886           

Flag	Coverage Δ
javascript	52.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more