Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pie chart orientation description error #21514

Merged
merged 2 commits into from
Sep 21, 2022
Merged

fix: pie chart orientation description error #21514

merged 2 commits into from
Sep 21, 2022

Conversation

LiuBodong
Copy link
Contributor

Fix orientation description error

fix(charts) pie chart orientation description error

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
图片

After
图片

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI

Fixes #21513

Fix orientation description error
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #21514 (cb24995) into master (7d2f07e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21514   +/-   ##
=======================================
  Coverage   66.67%   66.68%           
=======================================
  Files        1793     1793           
  Lines       68493    68536   +43     
  Branches     7275     7282    +7     
=======================================
+ Hits        45665    45700   +35     
- Misses      20966    20974    +8     
  Partials     1862     1862           
Flag Coverage Δ
javascript 52.86% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/plugins/plugin-chart-echarts/src/controls.tsx 72.72% <ø> (ø)
...frontend/src/components/ListView/Filters/index.tsx 52.17% <0.00%> (-14.50%) ⬇️
...src/dashboard/components/PropertiesModal/index.tsx 61.07% <0.00%> (-0.75%) ⬇️
...rset-frontend/src/explore/components/SaveModal.tsx 38.53% <0.00%> (-0.52%) ⬇️
superset-frontend/src/SqlLab/constants.ts 100.00% <0.00%> (ø)
...set-frontend/src/explore/actions/hydrateExplore.ts 42.10% <0.00%> (ø)
...ns/plugin-chart-word-cloud/src/chart/WordCloud.tsx 0.00% <0.00%> (ø)
...in-chart-echarts/src/MixedTimeseries/buildQuery.ts 100.00% <0.00%> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
...-ui-chart-controls/src/operators/renameOperator.ts 100.00% <0.00%> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stephenLYZ stephenLYZ changed the title Fix pie chart orientation description error fix: pie chart orientation description error Sep 21, 2022
@stephenLYZ stephenLYZ merged commit c66205f into apache:master Sep 21, 2022
@rusackas
Copy link
Member

@LiuBodong thank you for bringing this to our attention, and thank you for your first PR!

After seeing this though, I think since the tooltip is the same as the control label itself, it's redundant and we can simply remove it. Would you be OK with opening a PR to do that, or should I?

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: chart-plugin-echarts does not show Orientation description correctly
4 participants