-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pie chart orientation description error #21514
fix: pie chart orientation description error #21514
Conversation
Fix orientation description error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!
superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #21514 +/- ##
=======================================
Coverage 66.67% 66.68%
=======================================
Files 1793 1793
Lines 68493 68536 +43
Branches 7275 7282 +7
=======================================
+ Hits 45665 45700 +35
- Misses 20966 20974 +8
Partials 1862 1862
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@LiuBodong thank you for bringing this to our attention, and thank you for your first PR! After seeing this though, I think since the tooltip is the same as the control label itself, it's redundant and we can simply remove it. Would you be OK with opening a PR to do that, or should I? |
Fix orientation description error
fix(charts) pie chart orientation description error
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
![图片](https://user-images.githubusercontent.com/23203149/190990012-64b23fa2-2891-46d7-ae85-8b635cf00c52.png)
After
![图片](https://user-images.githubusercontent.com/23203149/190995313-0a8cbc8b-75c2-43cf-a134-ba327b7767ea.png)
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
Fixes #21513