chore: should return if get a exception in Dashboard edit modal #21524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
requested review from
etr2460,
john-bodley,
stephenLYZ and
geido
zhaoyongjie
commented
Sep 20, 2022
Comment on lines
-24
to
+32
| import { AsyncSelect, Row, Col, AntdForm } from 'src/components'; | ||
| import { AntdForm, AsyncSelect, Col, Row } from 'src/components'; | ||
| import rison from 'rison'; | ||
| import { | ||
| styled, | ||
| t, | ||
| SupersetClient, | ||
| getCategoricalSchemeRegistry, | ||
| ensureIsArray, | ||
| getCategoricalSchemeRegistry, | ||
| getSharedLabelColor, | ||
| styled, | ||
| SupersetClient, | ||
| t, |
zhaoyongjie
commented
Sep 20, 2022
Comment on lines
+303
to
+315
| let metadata; | ||
| try { | ||
| if ( | ||
| !currentJsonMetadata.startsWith('{') || | ||
| !currentJsonMetadata.endsWith('}') | ||
| ) { | ||
| throw new Error(); | ||
| } | ||
| metadata = JSON.parse(currentJsonMetadata); | ||
| } catch (error) { | ||
| addDangerToast(t('JSON metadata is invalid!')); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Move the validated logic out of the if clause. Add return statement in catch case,
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #21524 +/- ##
==========================================
- Coverage 66.67% 66.66% -0.01%
==========================================
Files 1793 1793
Lines 68493 68500 +7
Branches 7275 7279 +4
==========================================
Hits 45665 45665
- Misses 20966 20971 +5
- Partials 1862 1864 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
According to the discussion here, make a minor refactor to validate the JSON string to make sure the
currentJsonMetadatamust be a validated JSON string and it should be in '{}'BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
validate.JSON.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION