Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use queryEditorId in SqlEditor child components #21650

Merged
merged 11 commits into from
Nov 16, 2022
Merged

chore: Use queryEditorId in SqlEditor child components #21650

merged 11 commits into from
Nov 16, 2022

Conversation

EugeneTorap
Copy link
Contributor

SUMMARY

Fix potential re-rendering in SqlEditor child components.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@EugeneTorap EugeneTorap mentioned this pull request Sep 29, 2022
Merged
9 tasks
@EugeneTorap EugeneTorap marked this pull request as draft September 29, 2022 16:29
@EugeneTorap
Merge branch 'master' into chore/use-editor-id-for-props
3a8a7e5 
# Conflicts:
#	superset-frontend/src/SqlLab/components/QueryLimitSelect/QueryLimitSelect.test.tsx
#	superset-frontend/src/SqlLab/components/QueryLimitSelect/index.tsx
#	superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx
#	superset-frontend/src/SqlLab/components/SaveQuery/SaveQuery.test.tsx
#	superset-frontend/src/SqlLab/components/SaveQuery/index.tsx
#	superset-frontend/src/SqlLab/components/ShareSqlLabQuery/ShareSqlLabQuery.test.tsx
#	superset-frontend/src/SqlLab/components/ShareSqlLabQuery/index.tsx
#	superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Oct 3, 2022
@EugeneTorap EugeneTorap marked this pull request as ready for review October 6, 2022 09:32
@codecov
Copy link

codecov bot commented Oct 6, 2022 •
edited

Codecov Report

Merging #21650 (8e68df5) into master (c3f1873) will increase coverage by 0.05%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master   #21650      +/-   ##
==========================================
+ Coverage   66.94%   67.00%   +0.05%     
==========================================
  Files        1831     1829       -2     
  Lines       69833    69798      -35     
  Branches     7570     7570              
==========================================
+ Hits        46749    46767      +18     
+ Misses      21126    21073      -53     
  Partials     1958     1958
Flag Coverage Δ
javascript 53.78% <70.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/SqlLab/components/SqlEditor/index.jsx 55.91% <ø> (ø)
superset-frontend/src/SqlLab/fixtures.ts 100.00% <ø> (ø)
...frontend/src/components/DatabaseSelector/index.tsx 92.53% <ø> (ø)
...et-frontend/src/components/TableSelector/index.tsx 77.63% <ø> (ø)
...d/src/SqlLab/components/SqlEditorLeftBar/index.tsx 52.05% <57.69%> (+1.30%) ⬆️
...c/SqlLab/components/TemplateParamsEditor/index.tsx 83.33% <66.66%> (+0.98%) ⬆️
...qlLab/components/EstimateQueryCostButton/index.tsx 61.90% <100.00%> (-1.74%) ⬇️
...d/src/SqlLab/components/QueryLimitSelect/index.tsx 100.00% <100.00%> (ø)
...c/SqlLab/components/RunQueryActionButton/index.tsx 78.78% <100.00%> (ø)
...frontend/src/SqlLab/components/SaveQuery/index.tsx 75.55% <100.00%> (+0.55%) ⬆️
... and 72 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje
Copy link
Member

kgabryje commented Oct 6, 2022

/testenv up

@kgabryje
Copy link
Member

kgabryje commented Oct 6, 2022

Code looks great! @jinghua-qa Could you please help with testing SqlLab?

@EugeneTorap
Copy link
Contributor Author

@michael-s-molina Can also you review the PR?

michael-s-molina
michael-s-molina approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @EugeneTorap.

Code LGTM. We need @jinghua-qa's approval before merging it.

@michael-s-molina michael-s-molina added the need:qa-review Requires QA review label Nov 7, 2022
@EugeneTorap
Copy link
Contributor Author

@jinghua-qa @andrey-zayats Can you test the SQL Lab?

@jinghua-qa
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@jinghua-qa Ephemeral environment spinning up at http://35.87.28.70:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@jinghua-qa
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@jinghua-qa Ephemeral environment spinning up at http://54.202.195.0:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@jinghua-qa
Copy link
Member

test sqllab regression, LGTM!

@michael-s-molina michael-s-molina merged commit d76f305 into apache:master Nov 16, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@EugeneTorap EugeneTorap deleted the chore/use-editor-id-for-props branch November 16, 2022 13:09
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinpark justinpark justinpark left review comments

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@jinghua-qa jinghua-qa jinghua-qa approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:qa-review Requires QA review size/L 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@EugeneTorap @kgabryje @jinghua-qa @justinpark @michael-s-molina @mistercrunch