Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more logging for alerts and reports #21714

Merged
merged 5 commits into from
Oct 13, 2022

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Oct 6, 2022

SUMMARY

This pr is to add more logging for reports and alerts and so that if errors come up, they can be better pin pointed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pkdotson pkdotson marked this pull request as ready for review October 6, 2022 21:21
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #21714 (52209ed) into master (7b66e0b) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #21714      +/-   ##
==========================================
- Coverage   66.85%   66.85%   -0.01%     
==========================================
  Files        1799     1799              
  Lines       68875    68890      +15     
  Branches     7319     7319              
==========================================
+ Hits        46044    46054      +10     
- Misses      20944    20949       +5     
  Partials     1887     1887              
Flag Coverage Δ
hive 52.91% <0.00%> (-0.02%) ⬇️
mysql 78.24% <66.66%> (-0.01%) ⬇️
postgres 78.30% <66.66%> (-0.01%) ⬇️
presto 52.81% <0.00%> (-0.02%) ⬇️
python 81.45% <66.66%> (-0.01%) ⬇️
sqlite 76.79% <66.66%> (-0.02%) ⬇️
unit 50.95% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/tasks/scheduler.py 65.95% <0.00%> (-1.44%) ⬇️
superset/reports/commands/execute.py 91.98% <100.00%> (+0.02%) ⬆️
superset/models/sql_lab.py 74.80% <0.00%> (-1.72%) ⬇️
superset/db_engine_specs/gsheets.py 75.91% <0.00%> (-0.21%) ⬇️
superset/config.py 91.61% <0.00%> (ø)
superset/charts/schemas.py 99.35% <0.00%> (ø)
superset/explore/commands/get.py 90.42% <0.00%> (ø)
superset/queries/saved_queries/api.py 95.28% <0.00%> (ø)
superset/common/query_context_processor.py 88.51% <0.00%> (ø)
superset/databases/schemas.py 98.23% <0.00%> (+<0.01%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Oct 7, 2022
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AAfghahi AAfghahi merged commit f4fa2e1 into apache:master Oct 13, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants