Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(native-filters): reduce the re-rendering of native filter modal #21781

Merged
merged 4 commits into from
Oct 31, 2022

Conversation

stephenLYZ
Copy link
Member

@stephenLYZ stephenLYZ commented Oct 12, 2022

SUMMARY

We use why-did-you-render tool to measure the re-rendering of the native filter modal. This PR improves native filter modal in two scenarios (which has more than 20 native filters):

  • Enter the dashboard for the first time:

    • before: 1000+ re-rendering image

    • after: 0 re-rendering image

  • Close the native filter model:

    • before: 28 re-rendering image
    • after: 8 re-rendering image

In next PR I will improve the filter configure form in the modal.

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: perf(dashboard): Improve performance of the native filters config modal #21147
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #21781 (bffecea) into master (bf00193) will decrease coverage by 0.00%.
The diff coverage is 85.18%.

@@            Coverage Diff             @@
##           master   #21781      +/-   ##
==========================================
- Coverage   66.95%   66.95%   -0.01%     
==========================================
  Files        1807     1807              
  Lines       69231    69238       +7     
  Branches     7406     7407       +1     
==========================================
+ Hits        46357    46361       +4     
- Misses      20966    20968       +2     
- Partials     1908     1909       +1     
Flag Coverage Δ
javascript 53.40% <85.18%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 63.63% <80.00%> (-0.80%) ⬇️
...ilters/FilterBar/FilterConfigurationLink/index.tsx 100.00% <100.00%> (ø)
...omponents/nativeFilters/FilterBar/Header/index.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Can we get @jinghua-qa's approval before merging it?

@stephenLYZ stephenLYZ added the need:qa-review Requires QA review label Oct 15, 2022
@stephenLYZ stephenLYZ merged commit 66f166b into apache:master Oct 31, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:qa-review Requires QA review size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants