Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improves D2D loading indicator #21908

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Improves Drill to Detail loading indicator to show only one spinner when bootstrapping.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-10-21.at.9.40.21.AM.mov
Screen.Recording.2022-10-21.at.9.41.19.AM.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

Copy link
Member

@codyml codyml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tried some error states and they look fine:

Screen Shot 2022-10-21 at 7 09 10 AM

Screen Shot 2022-10-21 at 7 12 08 AM

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #21908 (2499fca) into master (40f8254) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #21908      +/-   ##
==========================================
- Coverage   66.91%   66.91%   -0.01%     
==========================================
  Files        1807     1807              
  Lines       69147    69141       -6     
  Branches     7395     7394       -1     
==========================================
- Hits        46273    46268       -5     
+ Misses      20964    20963       -1     
  Partials     1910     1910              
Flag Coverage Δ
javascript 53.33% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/components/Chart/DrillDetail/DrillDetailPane.tsx 82.71% <100.00%> (+0.43%) ⬆️
...ntend/src/components/MetadataBar/ContentConfig.tsx 85.00% <0.00%> (-5.00%) ⬇️
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 55.03% <0.00%> (-1.58%) ⬇️
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <0.00%> (ø)
...rc/explore/components/ExploreChartHeader/index.jsx 55.76% <0.00%> (ø)
...mponents/useExploreAdditionalActionsMenu/index.jsx 63.41% <0.00%> (+0.76%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit 3da9687 into apache:master Oct 21, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants