Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate ant d table component into DatasetPanel #21948

Conversation

eric-briscoe
Copy link
Contributor

@eric-briscoe eric-briscoe commented Oct 26, 2022

SUMMARY

Integrates a re-usable antd based Table into the DatasetPanel for new Dataset creation workflow

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

DatasetPanel.mov

TESTING INSTRUCTIONS

  1. Checkout this PR
  2. run Superset and navigate to: http://localhost:9000/dataset/add/?testing
  3. Select a database, schema, then table
  4. You should see table columns appear in table

You can also interact with the DatasetPanel in isolation via storybook:

  1. Checkout this PR
  2. run: npm run storybook
  3. navigate to http://localhost:6006/?path=/docs/supset-app-views-crud-data-dataset-datasetpanel--basic

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Very rough starting point for new table component
…sign system overview mdx, and Table overview mdx
…tation, fixes re-orderable drag drop columns issue
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #21948 (662115f) into master (736b534) will decrease coverage by 1.47%.
The diff coverage is 65.24%.

❗ Current head 662115f differs from pull request most recent head d40bf1a. Consider uploading reports for the commit d40bf1a to get more accurate results

@@            Coverage Diff             @@
##           master   #21948      +/-   ##
==========================================
- Coverage   67.09%   65.61%   -1.48%     
==========================================
  Files        1827     1829       +2     
  Lines       69866    69840      -26     
  Branches     7548     7570      +22     
==========================================
- Hits        46875    45826    -1049     
- Misses      21035    22056    +1021     
- Partials     1956     1958       +2     
Flag Coverage Δ
hive ?
javascript 53.77% <65.24%> (+0.04%) ⬆️
presto ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx 86.66% <ø> (+2.05%) ⬆️
...CRUD/data/dataset/AddDataset/DatasetPanel/types.ts 8.33% <8.33%> (ø)
...RUD/data/dataset/AddDataset/DatasetPanel/index.tsx 29.03% <29.03%> (-8.47%) ⬇️
...a/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx 91.30% <91.30%> (ø)
...dataset/AddDataset/DatasetPanel/MessageContent.tsx 96.66% <96.66%> (ø)
...erset-frontend/src/components/EmptyState/index.tsx 77.77% <100.00%> (+1.58%) ⬆️
...D/data/dataset/AddDataset/DatasetPanel/fixtures.ts 100.00% <100.00%> (ø)
...iews/CRUD/data/dataset/AddDataset/Footer/index.tsx 37.50% <100.00%> (+4.16%) ⬆️
...d/src/views/CRUD/data/dataset/AddDataset/index.tsx 60.00% <100.00%> (+2.10%) ⬆️
...set-frontend/src/views/CRUD/data/dataset/styles.ts 100.00% <100.00%> (ø)
... and 94 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pkdotson
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@pkdotson Ephemeral environment spinning up at http://54.213.38.241:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

eric-briscoe and others added 2 commits November 7, 2022 10:41
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
eric-briscoe and others added 11 commits November 7, 2022 16:41
…ll/ActionCell.overview.mdx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…ll/ActionCell.overview.mdx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…td' into ericbriscoe/sc-56078/create-dataset-add-antd-table-component-into
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…td' into ericbriscoe/sc-56078/create-dataset-add-antd-table-component-into
Copy link
Member

@AAfghahi AAfghahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question, it looks good but going to start an ephemeral for final testing. Specifically wanna check with different window sizes.

@AAfghahi
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@AAfghahi Ephemeral environment spinning up at http://35.89.122.245:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I found a couple of theming/TS things and also some act errors.

eric-briscoe and others added 3 commits November 10, 2022 14:25
Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work on this!

@lyndsiWilliams lyndsiWilliams merged commit defe5c8 into apache:master Nov 11, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants