Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashboard api cache decorator #21964

Conversation

dpgaspar
Copy link
Member

SUMMARY

Small refactor, @etag_cache needs to be on a different position on the decorators

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #21964 (8933daf) into master (102909e) will decrease coverage by 1.31%.
The diff coverage is 100.00%.

❗ Current head 8933daf differs from pull request most recent head 130ec4b. Consider uploading reports for the commit 130ec4b to get more accurate results

@@            Coverage Diff             @@
##           master   #21964      +/-   ##
==========================================
- Coverage   66.86%   65.54%   -1.32%     
==========================================
  Files        1807     1807              
  Lines       69218    69218              
  Branches     7402     7402              
==========================================
- Hits        46280    45370     -910     
- Misses      21033    21943     +910     
  Partials     1905     1905              
Flag Coverage Δ
mysql 78.36% <100.00%> (ø)
postgres 78.43% <100.00%> (ø)
presto ?
python 78.55% <100.00%> (-2.73%) ⬇️
sqlite 76.91% <100.00%> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/dashboards/api.py 92.52% <100.00%> (ø)
superset/tables/schemas.py 0.00% <0.00%> (-100.00%) ⬇️
superset/columns/schemas.py 0.00% <0.00%> (-100.00%) ⬇️
...set/advanced_data_type/plugins/internet_address.py 16.32% <0.00%> (-79.60%) ⬇️
superset/utils/pandas_postprocessing/boxplot.py 20.51% <0.00%> (-79.49%) ⬇️
superset/charts/post_processing.py 11.76% <0.00%> (-77.95%) ⬇️
...perset/advanced_data_type/plugins/internet_port.py 18.75% <0.00%> (-77.09%) ⬇️
superset/utils/pandas_postprocessing/rolling.py 21.87% <0.00%> (-68.75%) ⬇️
...perset/utils/pandas_postprocessing/contribution.py 34.61% <0.00%> (-65.39%) ⬇️
superset/utils/pandas_postprocessing/resample.py 37.50% <0.00%> (-62.50%) ⬇️
... and 51 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktmud
Copy link
Member

ktmud commented Oct 31, 2022

Was there anything breaking in the original code?

@dpgaspar
Copy link
Member Author

Was there anything breaking in the original code?

yes it was, further details on our pmc channel

@dpgaspar dpgaspar merged commit c9470ca into apache:master Oct 31, 2022
@dpgaspar dpgaspar deleted the danielgaspar/sc-61196/fix-etag-cache-issue-on-superset-reported branch October 31, 2022 10:26
AAfghahi pushed a commit that referenced this pull request Nov 1, 2022
eschutho pushed a commit that referenced this pull request Nov 2, 2022
AAfghahi pushed a commit that referenced this pull request Nov 18, 2022
AAfghahi pushed a commit that referenced this pull request Dec 15, 2022
michael-s-molina pushed a commit that referenced this pull request Jan 5, 2023
@mistercrunch mistercrunch added 🍒 1.5.3 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v1.5 v2.0 v2.0.1 🍒 1.5.3 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants