Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CSV File Upload form updates (Grouping with Collapse/Expand) #21992

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

Antonio-RiveroMartnez
Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez commented Nov 1, 2022

SUMMARY

This is a follow up PR based on #21922 (So I'd suggest checking that one first so we can rebase this PR). Here we are grouping some input groups into collapsable sections, so our users can have a better experience while uploading CSV files. Since this level of customization escape from FAB default views, we are creating a new one and adding the correspondent templates with macros.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
error

After:

test.mov

test

TESTING INSTRUCTIONS

  1. Open the CSV file upload form
  2. Check the form matches the proposed changes

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • [] Introduces new feature or API
  • Removes existing feature or API

@Antonio-RiveroMartnez Antonio-RiveroMartnez changed the title [draft] feat: CSV File Upload form updates (Grouping with Collapse/Expand) feat: CSV File Upload form updates (Grouping with Collapse/Expand) Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #21992 (76a1e52) into master (22fab5e) will decrease coverage by 0.74%.
The diff coverage is 48.83%.

❗ Current head 76a1e52 differs from pull request most recent head f266d22. Consider uploading reports for the commit f266d22 to get more accurate results

@@            Coverage Diff             @@
##           master   #21992      +/-   ##
==========================================
- Coverage   66.85%   66.10%   -0.75%     
==========================================
  Files        1841     1841              
  Lines       70197    70230      +33     
  Branches     7662     7664       +2     
==========================================
- Hits        46927    46426     -501     
- Misses      21296    21817     +521     
- Partials     1974     1987      +13     
Flag Coverage Δ
hive 52.54% <38.70%> (-0.02%) ⬇️
mysql ?
postgres ?
presto 52.44% <38.70%> (-0.02%) ⬇️
python 79.74% <41.93%> (-1.60%) ⬇️
sqlite 76.56% <41.93%> (-0.04%) ⬇️
unit 50.85% <35.48%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/dashboard/styles.ts 100.00% <ø> (ø)
...nts/controls/DateFilterControl/DateFilterLabel.tsx 58.13% <ø> (ø)
superset/connectors/sqla/models.py 88.72% <ø> (-0.60%) ⬇️
superset/models/helpers.py 38.19% <0.00%> (-0.09%) ⬇️
superset/views/database/views.py 31.27% <36.00%> (-0.09%) ⬇️
...nd/src/hooks/useTruncation/useCSSTextTruncation.ts 69.23% <55.55%> (-30.77%) ⬇️
...Filters/FilterBar/FilterControls/FilterDivider.tsx 81.48% <100.00%> (-18.52%) ⬇️
superset/connectors/base/models.py 87.20% <100.00%> (+0.07%) ⬆️
superset/views/database/forms.py 85.89% <100.00%> (+0.18%) ⬆️
superset/datasets/commands/create.py 30.61% <0.00%> (-69.39%) ⬇️
... and 38 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

  - Add expand/collapse to sections uisng custom macros
  - Add other delimiter text input using custom macros
  - Add custom jquery scripts to support our new features
- Add has_access decorator to new custom view so it is secure
- Fix formatting
@hughhhh hughhhh merged commit 2fd0a61 into apache:master Nov 30, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants