Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Axis sort in the Bar Chart V2 #21993
feat: Axis sort in the Bar Chart V2 #21993
Changes from 13 commits
33b5ede
6cd1327
9811f7c
21c1d58
dfadcc5
258c814
7c3c4ec
eb2c61c
535018e
100ff11
e0566a1
bbe5c36
9296c87
c225baa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought for the future: As
formData
will always be unstandardized (can contain more or less any property names), it will be difficult to harmonize functionality based onformData
. So at some point we should move to using a basequeryObject
, which has already been converted to specific format (columns
for dimensional grouping).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly, these operators are used to "build" part of
Query Object
. I recently found that we might only useformData
to generate an operator and don't use theQueryObject
.However, we need to consider more and more to see how to make an efficient and convenient abstraction on the queryObject generation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move
contributionMode
into CustomControls.tsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bycatch: rename the
datetime_columns_lookup
intotemporal_columns_lookup
.