refactor: clean up codes #22002
Merged
refactor: clean up codes #22002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
commented
Nov 2, 2022
| import { getUrlParam } from 'src/utils/urlUtils'; | ||
| import { URL_PARAMS } from 'src/constants'; | ||
| import { isNullish } from 'src/utils/common'; |
There was a problem hiding this comment.
replace isNullish with isDefined
| @@ -121,7 +117,7 @@ const changeFilterValue = async () => { | |||
| userEvent.click(screen.getAllByText('No filter')[0]); | |||
| userEvent.click(screen.getByDisplayValue('Last day')); | |||
| expect(await screen.findByText(/2021-04-13/)).toBeInTheDocument(); | |||
| userEvent.click(screen.getByTestId(getDateControlTestId('apply-button'))); | |||
| userEvent.click(screen.getByTestId(DATE_FILTER_TEST_KEY.applyButton)); | |||
There was a problem hiding this comment.
Keep simple logic for a simple use case.
Comment on lines
-177
to
-181
| setTooltipTitle( | ||
| type === ('error' as Type) | ||
| ? t('Default value is required') | ||
| : actualRange || '', | ||
| ); |
There was a problem hiding this comment.
Since the default value always gets from Store or constants, the value of the DateFilterControl will not be undefined.
So the type in the DateFilterControl is useless.
| @@ -302,7 +295,7 @@ export default function DateFilterLabel(props: DateFilterControlProps) { | |||
| disabled={!validTimeRange} | |||
| key="apply" | |||
| onClick={onSave} | |||
| {...getDateFilterControlTestId('apply-button')} | |||
| data-test={DATE_FILTER_TEST_KEY.applyButton} | |||
Codecov Report
@@ Coverage Diff @@
## master #22002 +/- ##
=======================================
Coverage 67.03% 67.03%
=======================================
Files 1813 1813
Lines 69437 69425 -12
Branches 7449 7447 -2
=======================================
- Hits 46545 46542 -3
+ Misses 20972 20963 -9
Partials 1920 1920
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR clears codes up. It's no logical change. I will add comments on the codes for the reviewer.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION