feat: auto select schema #22160
Merged
feat: auto select schema #22160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22160 +/- ##
==========================================
- Coverage 66.99% 66.99% -0.01%
==========================================
Files 1833 1833
Lines 69935 69936 +1
Branches 7571 7572 +1
==========================================
Hits 46855 46855
Misses 21121 21121
- Partials 1959 1960 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
/testenv up |
|
@lyndsiWilliams Ephemeral environment spinning up at http://34.211.99.17:8080. Credentials are |
|
This is awesome, works great in the test env! |
lyndsiWilliams
approved these changes
Nov 18, 2022
|
Ephemeral environment shutdown and build artifacts deleted. |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When choosing a database, if it has only a single schema, auto select it for the user.
I thought of doing the same when the schema has only a single table, but selecting a table triggers a preview and the user might not want to do that.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Load any database in SQL Lab that has only one schema.
ADDITIONAL INFORMATION