Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Empty Error Alert Modal #22186

Conversation

AAfghahi
Copy link
Member

SUMMARY

The Error Alert in the database modal was showing users a "See More" link that was displaying an empty modal.

Looking into this issue, there seemed to be a disconnect between a description and a body. With a body being the additional information that we want to display to a user should it not all fit in the original Error Alert. This PR adds a conditional to the Error Alert that checks for a body to be present in order to show the "See More" text.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:

Screen.Recording.2022-11-21.at.5.31.32.PM.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@AAfghahi
Copy link
Member Author

AAfghahi commented Nov 21, 2022

@zhaoyongjie I know that you have worked on this component before, interested in hearing your thoughts on the matter.

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #22186 (6cd2821) into master (78a4bd6) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 6cd2821 differs from pull request most recent head 424fd63. Consider uploading reports for the commit 424fd63 to get more accurate results

@@           Coverage Diff           @@
##           master   #22186   +/-   ##
=======================================
  Coverage   67.00%   67.00%           
=======================================
  Files        1835     1835           
  Lines       69971    69971           
  Branches     7590     7590           
=======================================
  Hits        46881    46881           
  Misses      21124    21124           
  Partials     1966     1966           
Flag Coverage Δ
javascript 53.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/components/ErrorMessage/ErrorAlert.tsx 90.24% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@apache apache deleted a comment from github-actions bot Nov 21, 2022
@apache apache deleted a comment from github-actions bot Nov 21, 2022
Copy link
Contributor

@eric-briscoe eric-briscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lyndsiWilliams
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@lyndsiWilliams Ephemeral environment spinning up at http://35.86.94.215:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simple fix!

@hughhhh hughhhh merged commit f885a18 into master Nov 22, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the arash.afghahi/sc-58084/databases-user-sees-an-empty-modal-when-trying branch March 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants