Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the TimePicker overlay the AdhocFilter #22234

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

When the GENERIC_CHART_AXES is enabled, the DateFilter in the modal has overlaid the AdhocFilter. This PR intends to fix it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

image

Before

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #22234 (2a8c036) into master (22fab5e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22234   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files        1841     1841           
  Lines       70197    70197           
  Branches     7662     7662           
=======================================
  Hits        46927    46927           
  Misses      21296    21296           
  Partials     1974     1974           
Flag Coverage Δ
javascript 53.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts/controls/DateFilterControl/DateFilterLabel.tsx 58.13% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We may need to start documenting or controlling these z-indexes more thoroughly at some point.

@zhaoyongjie
Copy link
Member Author

@michael-s-molina @geido the Modal and Popover components might need to define an appropriate/documenting zIndex property in them.

@zhaoyongjie zhaoyongjie merged commit 0fdc520 into apache:master Nov 28, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants