Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow datasource imports on Windows #22264

Merged
merged 1 commit into from
Nov 30, 2022
Merged

fix: allow datasource imports on Windows #22264

merged 1 commit into from
Nov 30, 2022

Commits on Nov 29, 2022

  1. Use PurePosixPath to fix imports on Windows 

    No sources are added when importing zip files on Windows, as file paths are parsed using `pathlib.PureWindowsPath`. Schemas are defined using prefixes with trailing slashes, therefore file paths in zipfiles should instead be treated as `pathlib.PurePosixPath`s.

Although Superset does not have official Windows support, this change fixes imports without changing the behaviour on Unix, since instantiating `pathlib.Path` creates a `pathlib.PurePosixPath`.
    @BTatlock
    BTatlock committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    9716a84 View commit details
    Browse the repository at this point in the history