Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(native-filters): Grid units, type guard, feature flag guard #22307

Merged
merged 6 commits into from
Dec 2, 2022

Conversation

codyml
Copy link
Member

@codyml codyml commented Dec 1, 2022

SUMMARY

This PR follows up on a few comments from previous PRs:

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No visible changes

TESTING INSTRUCTIONS

  • There shouldn't be any new lint/build errors
  • Horizontal overflow dividers should look (essentially) the same as before
  • If a filter bar is set to horizontal then the feature flag is turned off, checking the Redux state should show filterBarOrientation set to vertical

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: HORIZONTAL_FILTER_BAR
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #22307 (e46208c) into master (aa97ba4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #22307      +/-   ##
==========================================
- Coverage   65.59%   65.58%   -0.02%     
==========================================
  Files        1847     1847              
  Lines       70333    70367      +34     
  Branches     7702     7719      +17     
==========================================
+ Hits        46138    46150      +12     
- Misses      22197    22218      +21     
- Partials     1998     1999       +1     
Flag Coverage Δ
javascript 53.79% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/dashboard/actions/hydrate.js 1.78% <ø> (ø)
...ilters/FilterBar/FilterControls/FilterControls.tsx 68.62% <ø> (-1.59%) ⬇️
...Filters/FilterBar/FilterControls/FilterDivider.tsx 84.00% <ø> (ø)
...ages/superset-ui-core/src/query/types/Dashboard.ts 100.00% <100.00%> (ø)
...ativeFilters/FilterBar/useFilterControlFactory.tsx 81.81% <100.00%> (ø)
...nd/src/dashboard/components/nativeFilters/state.ts 64.28% <100.00%> (ø)
...t-frontend/src/dashboard/reducers/nativeFilters.ts 40.74% <0.00%> (-3.26%) ⬇️
...t-frontend/src/dashboard/actions/dashboardState.js 52.45% <0.00%> (-0.50%) ⬇️
...veFilters/FilterBar/FilterControls/FilterValue.tsx 6.00% <0.00%> (-0.32%) ⬇️
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgabryje kgabryje merged commit 997950e into apache:master Dec 2, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants