Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add tooltip to dropdown trigger in horizontal filter bar #22373

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Dec 8, 2022

SUMMARY

Adds a tooltip with list of applied filter names to the dropdown trigger in horizontal filter bar

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #22373 (266165e) into master (f64423a) will decrease coverage by 0.00%.
The diff coverage is 40.00%.

❗ Current head 266165e differs from pull request most recent head 185156f. Consider uploading reports for the commit 185156f to get more accurate results

@@            Coverage Diff             @@
##           master   #22373      +/-   ##
==========================================
- Coverage   66.87%   66.87%   -0.01%     
==========================================
  Files        1847     1847              
  Lines       70561    70564       +3     
  Branches     7739     7741       +2     
==========================================
+ Hits        47186    47187       +1     
- Misses      21374    21375       +1     
- Partials     2001     2002       +1     
Flag Coverage Δ
javascript 53.84% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ilters/FilterBar/FilterControls/FilterControls.tsx 64.81% <0.00%> (-2.50%) ⬇️
...rontend/src/components/DropdownContainer/index.tsx 73.17% <66.66%> (+0.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje kgabryje merged commit de4f509 into apache:master Dec 8, 2022
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Dec 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.49 size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants