Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct exception level in log and add error message #22381

Merged

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Dec 9, 2022

SUMMARY

Followup to #21971, this PR makes a slight correction to print the string value of the logger level in the logs, and also passes in the error message. I'm also including the stack trace for warning level logs.

TESTING INSTRUCTIONS

If you were to run this manually, you would see that error messages correctly say A downstream exception occurred while generating a report instead of A downstream LoggerLevel.EXCEPTION occurred while generating a report and also have an added message at the end of the log and a stack trace for both exceptions and warnings.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho force-pushed the elizabeth/improve-celery-error-log branch from e0de9ce to a87cc24 Compare December 9, 2022 23:10
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #22381 (3b4c7c5) into master (de4f509) will decrease coverage by 1.48%.
The diff coverage is 66.66%.

❗ Current head 3b4c7c5 differs from pull request most recent head a499cea. Consider uploading reports for the commit a499cea to get more accurate results

@@            Coverage Diff             @@
##           master   #22381      +/-   ##
==========================================
- Coverage   66.86%   65.37%   -1.49%     
==========================================
  Files        1847     1847              
  Lines       70562    70562              
  Branches     7741     7741              
==========================================
- Hits        47179    46130    -1049     
- Misses      21382    22431    +1049     
  Partials     2001     2001              
Flag Coverage Δ
hive ?
mysql 77.98% <100.00%> (+0.02%) ⬆️
postgres 78.04% <100.00%> (+0.02%) ⬆️
presto ?
python 78.10% <100.00%> (-3.13%) ⬇️
sqlite ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ugins/legacy-plugin-chart-pivot-table/src/index.js 66.66% <ø> (ø)
...d/plugins/legacy-plugin-chart-treemap/src/index.js 66.66% <ø> (ø)
...plugins/legacy-preset-chart-nvd3/src/Area/index.js 66.66% <ø> (ø)
.../plugins/legacy-preset-chart-nvd3/src/Bar/index.js 66.66% <ø> (ø)
...plugins/legacy-preset-chart-nvd3/src/Line/index.js 66.66% <ø> (ø)
.../plugin-chart-echarts/src/Timeseries/Area/index.ts 33.33% <ø> (ø)
...-chart-echarts/src/Timeseries/Regular/Bar/index.ts 33.33% <0.00%> (ø)
...chart-echarts/src/Timeseries/Regular/Line/index.ts 33.33% <ø> (ø)
.../plugins/plugin-chart-echarts/src/Treemap/index.ts 50.00% <ø> (ø)
...ugins/plugin-chart-pivot-table/src/plugin/index.ts 66.66% <ø> (ø)
... and 87 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eschutho eschutho force-pushed the elizabeth/improve-celery-error-log branch from a87cc24 to 0e15381 Compare December 10, 2022 02:03
@eschutho eschutho force-pushed the elizabeth/improve-celery-error-log branch from 0e15381 to a499cea Compare December 12, 2022 17:19
@eschutho eschutho merged commit c3a6327 into apache:master Dec 12, 2022
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Dec 12, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.49 size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants