-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow empty CSS in Handlebars #22422
fix: Allow empty CSS in Handlebars #22422
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22422 +/- ##
==========================================
- Coverage 66.90% 66.89% -0.01%
==========================================
Files 1850 1850
Lines 70677 70682 +5
Branches 7749 7752 +3
==========================================
Hits 47285 47285
- Misses 21376 21381 +5
Partials 2016 2016
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
<ControlHeader> | ||
<div> | ||
{props.label} | ||
<InfoTooltipWithTrigger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might be able to inspect the config, and only show this tooltip if it's not configured properly. And perhaps not show the code editor if it's not configured properly. But that's another PR...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Thank you!!!
SUMMARY
Allow empty CSS in Handlebars and also add a tooltip about the required HTML sanitization when using CSS.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-12-14.at.5.02.02.PM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION