chore(ssh-tunnel): Move SSHManager to extensions pattern #22433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craig-rueda
reviewed
Dec 15, 2022
superset/extensions/__init__.py
Outdated
| local_bind_address = "127.0.0.1" | ||
|
|
||
| @classmethod | ||
| def mutator(cls, sqlalchemy_url: str, server: sshtunnel.SSHTunnelForwarder) -> str: |
There was a problem hiding this comment.
naming: build_sqlalchemy_url
craig-rueda
reviewed
Dec 15, 2022
superset/extensions/__init__.py
Outdated
| remote_bind_address: str, | ||
| local_bind_address: str, | ||
| **kwargs: Dict[str, Any], | ||
| ) -> sshtunnel.SSHTunnelForwarder: |
There was a problem hiding this comment.
This should just return a ContextManager
craig-rueda
reviewed
Dec 15, 2022
superset/extensions/__init__.py
Outdated
| @classmethod | ||
| def create_tunnel( | ||
| cls, | ||
| ssh_address_or_host: str, |
There was a problem hiding this comment.
Instead of breaking these fields out, just pass in the SSHConfig model object
craig-rueda
reviewed
Dec 15, 2022
superset/extensions/__init__.py
Outdated
| @@ -109,6 +111,31 @@ def init_app(self, app: Flask) -> None: | |||
| app.wsgi_app = SupersetProfiler(app.wsgi_app, self.interval) # type: ignore | |||
|
|
|||
|
|
|||
| class SSHManager: # pylint: disable=too-few-public-methods | |||
| local_bind_address = "127.0.0.1" | |||
There was a problem hiding this comment.
This should implement init_app and should be wired up by the AppInitializer
Codecov Report
@@ Coverage Diff @@
## create-sshtunnelconfig-tbl #22433 +/- ##
===========================================================
Coverage 66.95% 66.96%
===========================================================
Files 1852 1853 +1
Lines 70512 70532 +20
Branches 7689 7689
===========================================================
+ Hits 47213 47232 +19
- Misses 21305 21306 +1
Partials 1994 1994
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hughhhh
force-pushed
the
sshmanager-2
branch
2 times, most recently
from
307162a
to
005bd35
Compare
hughhhh
force-pushed
the
sshmanager-2
branch
from
005bd35
to
1d52c1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION