Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unsupported REST API search col with dotted notation on c… #22440

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Dec 16, 2022

SUMMARY

Nested related fields are not supported on search_columns, FAB issues the following warning:

Filter type not supported for column: last_saved_by.id

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #22440 (f5192ab) into master (2679ee2) will decrease coverage by 11.17%.
The diff coverage is n/a.

❗ Current head f5192ab differs from pull request most recent head a998b55. Consider uploading reports for the commit a998b55 to get more accurate results

@@             Coverage Diff             @@
##           master   #22440       +/-   ##
===========================================
- Coverage   66.90%   55.73%   -11.18%     
===========================================
  Files        1850     1850               
  Lines       70701    70701               
  Branches     7750     7750               
===========================================
- Hits        47306    39402     -7904     
- Misses      21379    29283     +7904     
  Partials     2016     2016               
Flag Coverage Δ
hive 52.46% <ø> (ø)
mysql ?
postgres ?
presto 52.35% <ø> (ø)
python 57.78% <ø> (-23.47%) ⬇️
sqlite ?
unit 50.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/api.py 50.37% <ø> (-35.83%) ⬇️
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/tags/core.py 4.54% <0.00%> (-95.46%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-90.91%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-87.88%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-84.00%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/create.py 30.61% <0.00%> (-69.39%) ⬇️
superset/datasets/commands/update.py 25.00% <0.00%> (-69.05%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-69.00%) ⬇️
... and 282 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know! LGTM

@dpgaspar dpgaspar merged commit 277f8e0 into apache:master Dec 16, 2022
@dpgaspar dpgaspar deleted the fix/search-on-charts branch December 16, 2022 12:44
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants