Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjusting Alerts & reports docs to use the latest chromedriver #22517

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

rusackas
Copy link
Member

SUMMARY

Small tweak to the docs, as suggested by someone that solved their issue after encountering an error based on an unsupported chromedriver version. Now the docs will suggest using the latest version, rather than the incompatible one.
Fixes #20843

Hat tip to @nigzak for the suggestion.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #22517 (1e9b443) into master (9b26794) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22517   +/-   ##
=======================================
  Coverage   66.90%   66.90%           
=======================================
  Files        1851     1851           
  Lines       70696    70696           
  Branches     7764     7764           
=======================================
  Hits        47299    47299           
  Misses      21375    21375           
  Partials     2022     2022           
Flag Coverage Δ
hive 52.46% <ø> (ø)
javascript 53.85% <ø> (ø)
mysql 77.97% <ø> (ø)
postgres 78.04% <ø> (ø)
presto 52.36% <ø> (ø)
python 81.25% <ø> (ø)
sqlite 76.51% <ø> (ø)
unit 51.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think we should use pinned versions, WDYT?

docs/docs/installation/alerts-reports.mdx Outdated Show resolved Hide resolved
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@rusackas
Copy link
Member Author

rusackas commented Jan 6, 2023

@villebro followed your suggestion... let me know if you think we're good here :)

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rusackas rusackas merged commit 1bc2237 into master Jan 6, 2023
@rusackas rusackas deleted the updating-chromedriver-requirement branch January 30, 2023 18:55
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
3 participants