Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Talisman configuration #22591

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

#21874 introduced a CSP check for production environments but ended up making the Talisman configuration dependent on the CONTENT_SECURITY_POLICY_WARNING key. This PR fixes this by loading Talisman values independently of the CSP warning.

TESTING INSTRUCTIONS

1 - Play with Talisman configurations
2 - Check that the Talisman configurations are applied independently of the CSP warning

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #22591 (940a476) into master (82b0c23) will increase coverage by 9.56%.
The diff coverage is 83.33%.

❗ Current head 940a476 differs from pull request most recent head 9d8754a. Consider uploading reports for the commit 9d8754a to get more accurate results

@@            Coverage Diff             @@
##           master   #22591      +/-   ##
==========================================
+ Coverage   55.91%   65.48%   +9.56%     
==========================================
  Files        1859     1859              
  Lines       71019    71020       +1     
  Branches     7766     7766              
==========================================
+ Hits        39710    46504    +6794     
+ Misses      29287    22494    -6793     
  Partials     2022     2022              
Flag Coverage Δ
hive ?
postgres 78.07% <83.33%> (?)
presto ?
python 78.14% <83.33%> (+19.98%) ⬆️
sqlite 76.44% <83.33%> (?)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/initialization/__init__.py 89.76% <83.33%> (-1.30%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
...set/advanced_data_type/plugins/internet_address.py 16.32% <0.00%> (-79.60%) ⬇️
superset/utils/pandas_postprocessing/boxplot.py 20.51% <0.00%> (-79.49%) ⬇️
superset/charts/post_processing.py 11.76% <0.00%> (-77.95%) ⬇️
...perset/advanced_data_type/plugins/internet_port.py 18.75% <0.00%> (-77.09%) ⬇️
superset/utils/pandas_postprocessing/rolling.py 21.87% <0.00%> (-68.75%) ⬇️
...perset/utils/pandas_postprocessing/contribution.py 34.61% <0.00%> (-65.39%) ⬇️
superset/utils/pandas_postprocessing/resample.py 37.50% <0.00%> (-62.50%) ⬇️
superset/utils/pandas_postprocessing/select.py 38.46% <0.00%> (-61.54%) ⬇️
... and 325 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice if we could add a test to assert the config independence

@michael-s-molina michael-s-molina merged commit 84177cb into apache:master Jan 5, 2023
michael-s-molina added a commit that referenced this pull request Jan 5, 2023
(cherry picked from commit 84177cb)
michael-s-molina added a commit that referenced this pull request Jan 6, 2023
@lilykuang lilykuang added the v2.0 label Feb 23, 2023
lilykuang pushed a commit that referenced this pull request Feb 25, 2023
@mistercrunch mistercrunch added 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v1.5 🍒 1.5.3 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants