Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade react-resize-detector #22592

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented Jan 4, 2023

SUMMARY

  • upgrade react-resize-detector before upgrade react 18

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lilykuang lilykuang requested a review from a team January 4, 2023 21:55
@lilykuang lilykuang changed the title chore: upgrade react-redux and react-resize-detector chore: upgrade react-resize-detector Jan 4, 2023
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #22592 (12f2def) into master (2350e54) will not change coverage.
The diff coverage is n/a.

❗ Current head 12f2def differs from pull request most recent head 515ed29. Consider uploading reports for the commit 515ed29 to get more accurate results

@@           Coverage Diff           @@
##           master   #22592   +/-   ##
=======================================
  Coverage   67.00%   67.00%           
=======================================
  Files        1876     1876           
  Lines       71812    71812           
  Branches     7863     7863           
=======================================
  Hits        48115    48115           
  Misses      21671    21671           
  Partials     2026     2026           
Flag Coverage Δ
javascript 53.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lilykuang lilykuang merged commit e05ac85 into apache:master Jan 18, 2023
@lilykuang lilykuang deleted the upgrade-redux-resize branch January 18, 2023 01:25
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants