Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding missing examples in the gallery for several chart types #22597

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

yash-samsung
Copy link
Contributor

SUMMARY

Adding chart examples which were missing in the gallery for these chart types: Dual Line Chart, Event Flow, Filter box, Funnel Chart, Gauge Chart, Graph Chart, Handlebars, Multiple Line Charts, Radar Chart and Nightingale Rose Chart.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
pr_before
(Please note that text in red 'No Example' just to show/visualize that there are no examples. In actual, it remains empty)

After:
pr_after

Before there was no example at the time of selecting chart type in the gallery. Now examples will be loaded as it can be seen in the after image in lower right 'Examples' section. Above example is for Nightingale Rose Chart, but examples will also be loaded for these chart types: Dual Line Chart, Event Flow, Filter box, Funnel Chart, Gauge Chart, Graph Chart, Handlebars, Multiple Line Charts, Radar Chart

TESTING INSTRUCTIONS

At the time of selecting a chart type from the gallery, example will be visible for Dual Line Chart, Event Flow, Filter box, Funnel Chart, Gauge Chart, Graph Chart, Handlebars, Multiple Line Charts, Radar Chart and Nightingale Rose Chart as seen in the after screenshot above.

ADDITIONAL INFORMATION

  • Has associated issue: Fixes a part of [Gallery] Some chart type in gallery do not have example #16707
  • Required feature flags:
  • Changes UI: Only example images will be loaded on the UI. It won't change anything the way user interacts with UI.
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

…nel Chart, Gauge Chart, Graph Chart, Handlebars, Multiple Line Charts, Radar Chart and Nightingale Rose Chart.
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #22597 (80b6f0a) into master (b6d39d1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22597   +/-   ##
=======================================
  Coverage   66.91%   66.91%           
=======================================
  Files        1851     1851           
  Lines       70715    70715           
  Branches     7766     7766           
=======================================
  Hits        47320    47320           
  Misses      21373    21373           
  Partials     2022     2022           
Flag Coverage Δ
javascript 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugins/legacy-plugin-chart-event-flow/src/index.ts 50.00% <ø> (ø)
...tend/plugins/legacy-plugin-chart-rose/src/index.js 66.66% <ø> (ø)
...ins/legacy-preset-chart-nvd3/src/DualLine/index.js 66.66% <ø> (ø)
...ns/legacy-preset-chart-nvd3/src/LineMulti/index.js 66.66% <ø> (ø)
...d/plugins/plugin-chart-echarts/src/Funnel/index.ts 50.00% <ø> (ø)
...nd/plugins/plugin-chart-echarts/src/Gauge/index.ts 50.00% <ø> (ø)
...nd/plugins/plugin-chart-echarts/src/Graph/index.ts 50.00% <ø> (ø)
...nd/plugins/plugin-chart-echarts/src/Radar/index.ts 50.00% <ø> (ø)
...lugins/plugin-chart-handlebars/src/plugin/index.ts 66.66% <ø> (ø)
...c/visualizations/FilterBox/FilterBoxChartPlugin.js 66.66% <ø> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! ❤️

@villebro villebro changed the title fix: adding missing examples in the gallery for several chart types chore: adding missing examples in the gallery for several chart types Jan 5, 2023
@villebro villebro merged commit 6e4d6e5 into apache:master Jan 5, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants